Skip to content

Conversation

@jianjunzhong
Copy link

@jianjunzhong jianjunzhong commented Jan 13, 2026

…ad of by parameter passing

What does this PR do?

use get_device_name() for automatic device detection in RayWorkerGroup instead of by parameter passing

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data, cfg, reward
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Summary by CodeRabbit

  • Refactor
    • Improved device detection mechanism for better initialization handling.

✏️ Tip: You can customize this high-level summary in your review settings.

…ad of by parameter passing

Signed-off-by: jianjunzhong <jianjunzhong@foxmail.com>
@coderabbitai
Copy link

coderabbitai bot commented Jan 13, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Modified device initialization in RayWorkerGroup.__init__ to determine device name by calling get_device_name() function instead of extracting from kwargs with a "cuda" default.

Changes

Cohort / File(s) Summary
Device Name Initialization
verl/single_controller/ray/base.py
Changed device_name assignment from kwargs extraction with default value to a function call via get_device_name()

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐰 A device was named with care and grace,
No longer static, it found its place,
A function's call, so clean and bright,
Sets the device name just right! 💫

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c9c9f49 and 40167b2.

📒 Files selected for processing (1)
  • verl/single_controller/ray/base.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant